You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/07/18 18:25:01 UTC
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18744
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Creating a plan with partitioned top-n node with -1 input
cardinality led to having negative resource estimate and
hitting a precondtition, returning error:
"IllegalStateException: Mem estimate must be set"
This change adds handling for unknown cardinality.
Testing:
- added a planner test
Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
---
M fe/src/main/java/org/apache/impala/planner/SortNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
3 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18744/1
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
The code change lgtm. One comment about the test.
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test:
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@858
PS1, Line 858: # Relies on functional.alltypessmall not having stats and running this test with
Can we always rely on functional.alltypessmall not having stats ?
FWIW, PlannerTest.testKudu() creates a test-only external table without stats for a particular test.
Something similar could be an option. I am ok with the alltypessmall if we have used it elsewhere (or similar tables) with the no stats assumption.
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 20:42:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java
File fe/src/main/java/org/apache/impala/planner/SortNode.java:
http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@465
PS1, Line 465: getChild(0).cardinality_ * avgRowSize_
Maybe not quite in the scope of this patch but is it possible that we have cardinality == -1 AND avgRowSize_ < 0 because of corrupt stats? This way the product would be incorrect but positive so we don't recognise it as incorrect on the next line.
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:40:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11020/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:42:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18744
to look at the new patch set (#3).
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Creating a plan with partitioned top-n node with -1 input
cardinality led to having negative resource estimate and
hitting a precondtition, returning error:
"IllegalStateException: Mem estimate must be set"
This change adds handling for unknown cardinality.
Testing:
- added a planner test
Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
---
M fe/src/main/java/org/apache/impala/planner/SortNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
3 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18744/3
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8354/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:51:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:51:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test:
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@858
PS1, Line 858: # Relies on functional.alltypessmall not having stats and running this test with
> cardinality=unavailable in the plan at scan node ensures that the test will
sorry, mistyped: rely on it having stats -> rely on it NOT having stats
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:48:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java
File fe/src/main/java/org/apache/impala/planner/SortNode.java:
http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@465
PS1, Line 465: getChild(0).cardinality_ * avgRowSize_
> Maybe not quite in the scope of this patch but is it possible that we have
I thing that avgRowSize_ cannot be negative. We could add a precondition for that, but I would prefer to not do it this in the current commit to avoid breaking currently working queries.
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test:
http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@858
PS1, Line 858: # Relies on functional.tinytable not having stats and running this test with
> Can we always rely on functional.alltypessmall not having stats ?
cardinality=unavailable in the plan at scan node ensures that the test will break if functional.alltypessmall has stats.
Switched to functional,tinytable as I saw that we rely on it having stats in other tests
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:26:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:50:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 17:45:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8355/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:52:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 4:
I think the both Daniel and I started a GVO in parallel - I stopped mine
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 15:58:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18744
to look at the new patch set (#2).
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Creating a plan with partitioned top-n node with -1 input
cardinality led to having negative resource estimate and
hitting a precondtition, returning error:
"IllegalStateException: Mem estimate must be set"
This change adds handling for unknown cardinality.
Testing:
- added a planner test
Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
---
M fe/src/main/java/org/apache/impala/planner/SortNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
3 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18744/2
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11021/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 12:44:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Creating a plan with partitioned top-n node with -1 input
cardinality led to having negative resource estimate and
hitting a precondtition, returning error:
"IllegalStateException: Mem estimate must be set"
This change adds handling for unknown cardinality.
Testing:
- added a planner test
Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Reviewed-on: http://gerrit.cloudera.org:8080/18744
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/SortNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
3 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11443: Fix partitoned top-n with -1 input cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10989/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984
Gerrit-Change-Number: 18744
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 18:45:29 +0000
Gerrit-HasComments: No