You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/21 12:49:21 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13887: [Issue 13854][broker] Fix call sync method in async rest api for internalSetReplicatedSubscriptionStatus

codelipenghui commented on a change in pull request #13887:
URL: https://github.com/apache/pulsar/pull/13887#discussion_r789630875



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4577,12 +4575,10 @@ protected void internalSetReplicatedSubscriptionStatus(AsyncResponse asyncRespon
         }
     }
 
-    private void internalSetReplicatedSubscriptionStatusForNonPartitionedTopic(AsyncResponse asyncResponse,
-            String subName, boolean authoritative, boolean enabled) {
-        try {
-            // Redirect the request to the appropriate broker if this broker is not the owner of the topic
-            validateTopicOwnership(topicName, authoritative);
-
+    private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse,
+        String subName,boolean authoritative,boolean enabled) {

Review comment:
       ```suggestion
       private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse,
           String subName, boolean authoritative, boolean enabled) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org