You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by klucar <gi...@git.apache.org> on 2015/10/13 22:50:51 UTC

[GitHub] accumulo pull request: added conf.isFile() check

GitHub user klucar opened a pull request:

    https://github.com/apache/accumulo/pull/48

    added conf.isFile() check

    Fixes ACCUMULO-4026

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klucar/accumulo ACCUMULO-4026

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit b1718b0fc873266bebe416289419ccf026defaec
Author: klucar <kl...@gmail.com>
Date:   2015-10-13T20:48:54Z

    added conf.isFile() check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: added conf.isFile() check

Posted by klucar <gi...@git.apache.org>.

Github user klucar closed the pull request at:

    https://github.com/apache/accumulo/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: added conf.isFile() check

Posted by joshelser <gi...@git.apache.org>.

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/48#issuecomment-147850773
  
    The code reads that ACCUMULO_CLIENT_CONF_PATH is meant to be a file (not a directory). Maybe it would be good to also expand these changes to also include expanding it from a directory to $directory/client.conf instead of just ignoring the value?
    
    A unit test would also be super appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: added conf.isFile() check

Posted by joshelser <gi...@git.apache.org>.

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/48#issuecomment-149054361
  
    I ended up cherry-picking this in while I was figuring out the broken tests. If you can close this, it'd be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---