You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/20 20:47:21 UTC
[GitHub] [airflow] chethanuk-plutoflume opened a new pull request, #25202: AIP-47 - Migrate emr DAG to new design
chethanuk-plutoflume opened a new pull request, #25202:
URL: https://github.com/apache/airflow/pull/25202
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25202: AIP-47 - Migrate emr DAG to new design
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25202:
URL: https://github.com/apache/airflow/pull/25202#issuecomment-1195319829
static checks/docs falures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25202: AIP-47 - Migrate emr DAG to new design
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25202: AIP-47 - Migrate emr DAG to new design
URL: https://github.com/apache/airflow/pull/25202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #25202: AIP-47 - Migrate emr DAG to new design
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #25202:
URL: https://github.com/apache/airflow/pull/25202#discussion_r937898243
##########
tests/system/providers/amazon/aws/example_emr.py:
##########
@@ -124,3 +127,15 @@
step_checker,
cluster_remover,
)
+
+ from tests.system.utils.watcher import watcher
+
+ # This test needs watcher in order to properly mark success/failure
+ # when "tearDown" task with trigger rule is part of the DAG
+ list(dag.tasks) >> watcher()
Review Comment:
Which task is the teardown task in this DAG? Should the "remove_cluster" task have a `trigger_rule` of `ALL_DONE` (assuming this is the teardown task).
If there isn't a teardown task then [the `watcher()` isn't needed](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-47+New+design+of+Airflow+System+Tests#AIP47NewdesignofAirflowSystemTests-Processofmigrationindetails:~:text=If%20you%20have%20a%20teardown%20task%20(with%20TriggerRule.ALL_DONE)%2C%20you%20need%20to%20add%20the%20watcher%20task%20dependency%20for%20all%20other%20tasks%20by%20adding%20these%20lines%20of%20code%20below%20all%20other%20task%20dependencies%3A).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25202: AIP-47 - Migrate emr DAG to new design
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25202:
URL: https://github.com/apache/airflow/pull/25202#issuecomment-1250419436
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org