You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/13 12:09:59 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request, #4661: [INLONG-4660][Manager] Fix PluginServiceTest in Windows System
kipshi opened a new pull request, #4661:
URL: https://github.com/apache/incubator-inlong/pull/4661
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/incubator-inlong/issues) number)*
- Fixes #4660
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4661: [INLONG-4660][Manager] PluginServiceTest adapts to the Windows system
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4661:
URL: https://github.com/apache/incubator-inlong/pull/4661#discussion_r895754700
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/plugin/PluginServiceTest.java:
##########
@@ -37,8 +38,18 @@ public class PluginServiceTest extends ServiceBaseTest {
@Test
public void testReloadPlugin() {
- String path = Objects.requireNonNull(this.getClass().getClassLoader().getResource("")).getPath();
- pluginService.setPluginLoc(path + "plugins");
+ String path = null;
+ try {
+ path = Paths.get(this.getClass().getClassLoader().getResource("").toURI()).toString();
+ } catch (URISyntaxException e) {
+ Assert.fail(e.getMessage());
+ }
+ String os = System.getProperty("os.name").toLowerCase();
+ if (os.startsWith(PluginClassLoader.WINDOWS_PREFIX)) {
+ pluginService.setPluginLoc(path + "\\plugins");
Review Comment:
Maybe using a constant for `plugins` and `File.separator` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a diff in pull request #4661: [INLONG-4660][Manager] PluginServiceTest adapts to the Windows system
Posted by GitBox <gi...@apache.org>.
kipshi commented on code in PR #4661:
URL: https://github.com/apache/incubator-inlong/pull/4661#discussion_r896326441
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/plugin/PluginServiceTest.java:
##########
@@ -37,8 +38,18 @@ public class PluginServiceTest extends ServiceBaseTest {
@Test
public void testReloadPlugin() {
- String path = Objects.requireNonNull(this.getClass().getClassLoader().getResource("")).getPath();
- pluginService.setPluginLoc(path + "plugins");
+ String path = null;
+ try {
+ path = Paths.get(this.getClass().getClassLoader().getResource("").toURI()).toString();
+ } catch (URISyntaxException e) {
+ Assert.fail(e.getMessage());
+ }
+ String os = System.getProperty("os.name").toLowerCase();
+ if (os.startsWith(PluginClassLoader.WINDOWS_PREFIX)) {
+ pluginService.setPluginLoc(path + "\\plugins");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4661: [INLONG-4660][Manager] PluginServiceTest adapts to the Windows system
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4661:
URL: https://github.com/apache/incubator-inlong/pull/4661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org