You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/19 04:08:07 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30418: [SPARK-33483][INFRA][TESTS] Fix rat exclusion patterns and add a LICENSE
dongjoon-hyun commented on a change in pull request #30418:
URL: https://github.com/apache/spark/pull/30418#discussion_r526581439
##########
File path: dev/.rat-excludes
##########
@@ -42,11 +42,11 @@ jquery.dataTables.1.10.20.min.js
jquery.mustache.js
jsonFormatter.min.css
jsonFormatter.min.js
-.*avsc
-.*txt
-.*json
-.*data
-.*log
+.*\.avsc
+.*\.txt
+.*\.json
+.*\.data
Review comment:
This hides the directory `data` and `metadata`.
##########
File path: dev/.rat-excludes
##########
@@ -42,11 +42,11 @@ jquery.dataTables.1.10.20.min.js
jquery.mustache.js
jsonFormatter.min.css
jsonFormatter.min.js
-.*avsc
-.*txt
-.*json
-.*data
-.*log
+.*\.avsc
+.*\.txt
+.*\.json
+.*\.data
+.*\.log
Review comment:
This hides `catalog` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org