You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2017/01/20 17:38:56 UTC
[GitHub] brooklyn-dist pull request #80: Add missing @Override annotations and other ...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-dist/pull/80
Add missing @Override annotations and other cleanup
Triggered by a refactoring I had to do and missing a bunch of places that needed updating.
* add missing `@Override` annotations
* add missing `@Deprecated` annotations (usually just javadoc `@override` exists)
* remove unused imports
* remove unnecessary casts
Look at each commit individually.
Similar PRs created for the other brooklyn sub-projects.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-dist cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit fe71e6f14cf00738ccb8b1a69638e42c5b3b95cf
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:08:18Z
Add missing @Override annotation to method signatures overriding interface methods
commit 0cf40aac1a76010c0cd9a45a78704acd8603621f
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:28:17Z
Remove unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #80: Add missing @Override annotations and other cleanup
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/80
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #80: Add missing @Override annotations and other ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---