You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2023/01/03 15:45:02 UTC

[GitHub] [knox] zeroflag commented on a diff in pull request #706: KNOX-2860 - Build the knox-webshell-ui project the same way as we build other UIs

zeroflag commented on code in PR #706:
URL: https://github.com/apache/knox/pull/706#discussion_r1060709664


##########
knox-webshell-ui/angular.json:
##########
@@ -54,18 +54,8 @@
           },
           "configurations": {
             "production": {
-              "budgets": [
-                {
-                  "type": "initial",
-                  "maximumWarning": "500kb",
-                  "maximumError": "1mb"
-                },
-                {
-                  "type": "anyComponentStyle",
-                  "maximumWarning": "2kb",
-                  "maximumError": "4kb"
-                }
-              ],
+              "buildOptimizer": false,
+              "aot": false,

Review Comment:
   How does disabling ahead of time compilation affects the runtime performance?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org