You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/02 08:38:02 UTC
[GitHub] [incubator-doris] Kikyou1997 opened a new pull request, #9941: [Enhancement] Column prune for olap scan node
Kikyou1997 opened a new pull request, #9941:
URL: https://github.com/apache/incubator-doris/pull/9941
# Proposed changes
Add Column prune for olap scan node based on the project planner framework
## Problem Summary:
Implement the `initOutputSlotIds` method
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Kikyou1997 closed pull request #9941: [Enhancement] Column prune for olap scan node
Posted by GitBox <gi...@apache.org>.
Kikyou1997 closed pull request #9941: [Enhancement] Column prune for olap scan node
URL: https://github.com/apache/incubator-doris/pull/9941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9941: [Enhancement] Column prune for olap scan node
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#discussion_r887773039
##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -984,4 +984,17 @@ public String toString() {
sb.append("\n").append(getNodeExplainString("", TExplainLevel.BRIEF));
return sb.toString();
}
+
+ /**
+ * Used to append some common explains to output
+ */
+ protected void appendCommonExplainString(String detailPrefix, StringBuilder output) {
Review Comment:
It seems that there is already a getExplainString in the plan node for common string output.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -941,4 +943,17 @@ public DataPartition constructInputPartitionByDistributionInfo() throws UserExce
return DataPartition.RANDOM;
}
}
+
+ @Override
+ public void initOutputSlotIds(Set<SlotId> requiredSlotIdSet, Analyzer analyzer) throws NotImplementedException {
Review Comment:
Although fe calculates the output slot of the scan node, if be does not make any changes, the function of project cannot be realized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zenoyang commented on pull request #9941: [Enhancement] Column prune for olap scan node
Posted by GitBox <gi...@apache.org>.
zenoyang commented on PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#issuecomment-1148169273
Excuse me, why close pr, is there any plan for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Kikyou1997 commented on a diff in pull request #9941: [Enhancement] Column prune for olap scan node
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#discussion_r887785975
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -941,4 +943,17 @@ public DataPartition constructInputPartitionByDistributionInfo() throws UserExce
return DataPartition.RANDOM;
}
}
+
+ @Override
+ public void initOutputSlotIds(Set<SlotId> requiredSlotIdSet, Analyzer analyzer) throws NotImplementedException {
Review Comment:
OK, I'll add supports in BE later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on pull request #9941: [Enhancement] Column prune for olap scan node
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#issuecomment-1144643467
Do not need any changes in BE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org