[GitHub] reta commented on a change in pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans

[GitBox <gi...@apache.org>]

reta commented on a change in pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans
URL: https://github.com/apache/cxf/pull/339#discussion_r150854464
 
 

 ##########
 File path: integration/cdi/src/main/java/org/apache/cxf/cdi/CdiClassUnwrapper.java
 ##########
 @@ -22,8 +22,18 @@
 
 import org.apache.cxf.common.util.ClassUnwrapper;
 
+/**
+ * Unwraps the CDI proxy classes into real classes.
+ */
 class CdiClassUnwrapper implements ClassUnwrapper {
-    private static final Pattern PROXY_PATTERN = Pattern.compile(".+\\$\\$.+Proxy");
+    /**
+     * Known proxy patterns for OWB and Weld:
+     * 
+     *  Xxx$$OwbNormalScopeProxy0
+     *  Xxx$Proxy$_$$_WeldClientProxy
+     *  
+     */
+    private static final Pattern PROXY_PATTERN = Pattern.compile(".+\\$\\$.+Proxy\\d*");
 
 Review comment:
   I see it consistently on OWB but it may not be always (hereby `\d*` to make this part optional)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services