[Impala-ASF-CR] IMPALA-3924: Ubuntu16 support

["Matthew Jacobs (Code Review)" <ge...@cloudera.org>]

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3924: Ubuntu16 support
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3800/3/bin/impala-config.sh
File bin/impala-config.sh:

PS3, Line 310: export PATH=$IMPALA_HOME/bin:$PATH
Let's actually add our cmake to the path rather than using the CMAKE_CMD variable in the other file. That'd be better because it looks like we also call cmake in buildall.sh for the lzo binary.


http://gerrit.cloudera.org:8080/#/c/3800/3/bin/make_impala.sh
File bin/make_impala.sh:

PS3, Line 29: CMAKE_CMD="$IMPALA_TOOLCHAIN/cmake-$IMPALA_CMAKE_VERSION/bin/cmake"
let's remove this here and instead put this directory in the PATH, see my comment in impala-config.sh


-- 
To view, visit http://gerrit.cloudera.org:8080/3800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes