You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2013/01/10 16:20:12 UTC

[jira] [Updated] (SYNCOPE-241) Move persistence and persistence impl into separate modules

     [ https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated SYNCOPE-241:
----------------------------------------

    Attachment: SYNCOPE-241-3.patch

I had too many problems doing the move in one step so I split this up. 

In this first patch I resolve issues where persistence tests refer to do classes outside persistence. This patch does not yet change the spring contexts of the persistence tests or move classes into the persistence module.

In detail:

- Resolve a new cyclic dependency in SyncActions which should not refer to SyncopeSyncResultHandler which is outside of persistence
- Moving the tests that need the PasswordGenerator out of persistence
- Switch all persistence tests to a new AbstractDAOTest that is inside peristence to avoid the reference to AbstractTest in core
- Moving the TaksTest methods that use TestSyncActions out of persitence into SyncTaskTest as these need stuff outside persistence
- Moving the ResoureTest methods that use ResourceDataBinder into a new test class ResourceDataTest outside persistence

                
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
>                 Key: SYNCOPE-241
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-241
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0.3-incubating
>            Reporter: Christian Schneider
>             Fix For: 1.1.0
>
>         Attachments: SYNCOPE-241-2.patch, SYNCOPE-241-3.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it bigger and more complex than necessary.
> A possible modularization is to move the internal model (org.apache.syncope.core.persistence*) and the persistence impl (org.apache.syncope.core.persistence.impl) out of core and into separate modules.
> One big advantage would be that the jpa code enhancements would then run in the model module only. Currently we run into some problems in the cxf migration when running the rest itests in core that may be caused by eclipse overwriting the enhanced classes with plain classes. If the model (peristence) classes are in a separate module we could leave it out of eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the persistence impl module so when working on the core they would not have to run each time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira