[GitHub] [thrift] belugabehr commented on a change in pull request #2399: THRIFT-5411: Catch SocketTimeoutException in TIOStreamTransport read

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #2399:
URL: https://github.com/apache/thrift/pull/2399#discussion_r640023784



##########
File path: lib/java/src/org/apache/thrift/transport/TIOStreamTransport.java
##########
@@ -174,6 +175,8 @@ public int read(byte[] buf, int off, int len) throws TTransportException {
     int bytesRead;
     try {
       bytesRead = inputStream_.read(buf, off, len);
+    } catch (SocketTimeoutException ste) {
+      throw new TTransportException(TTransportException.TIMED_OUT, ste);

Review comment:
       Hey @fishy. the code I am proposing does just that.
   
   Translating (wrapping) `SocketTimeoutException` into `TTransportException` :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org