[GitHub] [spark] sarutak commented on a change in pull request #33981: [SPARK-36733][SQL] Fix a perf issue in SchemaPruning when a struct has many fields

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #33981:
URL: https://github.com/apache/spark/pull/33981#discussion_r707941027



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3768,6 +3768,24 @@ class SQLConf extends Serializable with Logging {
     }
   }
 
+  /**
+   * Returns the [[Comparator]] for the current configuration,
+   * which can be used to compare two identifiers.
+   */
+  private[sql] def comparator: Comparator = {
+    if (caseSensitiveAnalysis) {
+      org.apache.spark.sql.catalyst.analysis.caseSensitiveComparator
+    } else {
+      org.apache.spark.sql.catalyst.analysis.caseInsensitiveComparator
+    }
+  }
+
+  private[sql] val fieldNameOrdering = new Ordering[String] {

Review comment:
       Thank you. It's reasonable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org