You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/25 16:41:23 UTC
[GitHub] [geode-native] pdxcodemonkey opened a new pull request #623: GEODE-8297: fix tcrmessage timeout
pdxcodemonkey opened a new pull request #623:
URL: https://github.com/apache/geode-native/pull/623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey merged pull request #623: GEODE-8297: fix tcrmessage timeout
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #623:
URL: https://github.com/apache/geode-native/pull/623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #623: GEODE-8297: fix tcrmessage timeout
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #623:
URL: https://github.com/apache/geode-native/pull/623#discussion_r445712619
##########
File path: cppcache/src/TcrMessage.cpp
##########
@@ -124,7 +124,7 @@ TcrMessage::TcrMessage()
m_chunkedResult(nullptr),
m_keyList(nullptr),
m_region(nullptr),
- m_timeout(15 /*DEFAULT_TIMEOUT_SECONDS*/),
+ m_timeout(DEFAULT_TIMEOUT_SECONDS),
Review comment:
Could you correct the name of the constant. Given it is now a `std::chrono::duration` the time unit qualifier on the end of the constant name doesn't make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org