You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/03 22:17:57 UTC
[GitHub] [druid] themarcelor opened a new issue #12112: Add http response status code to org.eclipse.jetty.server.RequestLog
themarcelor opened a new issue #12112:
URL: https://github.com/apache/druid/issues/12112
Can you please augment the jetty logger to also present the HTTP response code? 🙏🏼
We just need to add `response.getStatus()` to this class:
```public class JettyRequestLog extends AbstractLifeCycle implements RequestLog
{
private static final Logger logger = new Logger("org.apache.druid.jetty.RequestLog");
@Override
public void log(Request request, Response response)
{
if (logger.isDebugEnabled()) {
logger.debug(
"%s %s %s %s %s",
request.getRemoteAddr(),
request.getMethod(),
request.getHttpURI().toString(),
request.getProtocol(),
response.getStatus()
);
}
}
}
```
This would be extremely helpful to calculate the SR (Success Rate) based on the percentage of non-http-5xx requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] themarcelor commented on issue #12112: Add http response status code to org.eclipse.jetty.server.RequestLog
Posted by GitBox <gi...@apache.org>.
themarcelor commented on issue #12112:
URL: https://github.com/apache/druid/issues/12112#issuecomment-1004521857
There you go:
https://github.com/apache/druid/pull/12116
Please provide some handholding around testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 closed issue #12112: Add http response status code to org.eclipse.jetty.server.RequestLog
Posted by GitBox <gi...@apache.org>.
FrankChen021 closed issue #12112:
URL: https://github.com/apache/druid/issues/12112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on issue #12112: Add http response status code to org.eclipse.jetty.server.RequestLog
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on issue #12112:
URL: https://github.com/apache/druid/issues/12112#issuecomment-1004471330
You can open a PR to do it by yourself, I think it will be accepted since it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on issue #12112: Add http response status code to org.eclipse.jetty.server.RequestLog
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on issue #12112:
URL: https://github.com/apache/druid/issues/12112#issuecomment-1006532146
Closed via #12116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org