You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2017/08/01 20:15:32 UTC
svn commit: r1803699 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser:
BaseParser.java COSParser.java
Author: tilman
Date: Tue Aug 1 20:15:31 2017
New Revision: 1803699
URL: http://svn.apache.org/viewvc?rev=1803699&view=rev
Log:
PDFBOX-2852: remove unneeded nullcheck; improve javadoc
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java?rev=1803699&r1=1803698&r2=1803699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java Tue Aug 1 20:15:31 2017
@@ -188,7 +188,7 @@ public abstract class BaseParser
/**
* This will parse a PDF dictionary.
*
- * @return The parsed dictionary.
+ * @return The parsed dictionary, never null.
*
* @throws IOException If there is an error reading the stream.
*/
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1803699&r1=1803698&r2=1803699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Tue Aug 1 20:15:31 2017
@@ -1220,7 +1220,7 @@ public class COSParser extends BaseParse
// check the dictionary to avoid false positives
COSDictionary dict = parseCOSDictionary();
source.seek(startXRefOffset);
- if (dict != null && "XRef".equals(dict.getNameAsString(COSName.TYPE)))
+ if ("XRef".equals(dict.getNameAsString(COSName.TYPE)))
{
return true;
}