You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/10 05:21:07 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #3744: Build with JDK-11 in all Travis jobs
JaroslavTulach opened a new pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744
NetBeans are supposed to be developed with JDK-11 yet nobody updated Travis jobs to do so yet. Adding `nbbuild/travis/ant.sh` script which downloads JDK-11. Using it for compilation, but not for testing. Testing continues to be performed on the JDK the job has been setup for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065266776
wondering if we can remove the "Compile with JDK-11 and test something on JDK-8 " gh job if this PR makes it in.
I also have to agree with Neil, we should not use two different scripts for downloading JDKs if there is a reasonable way to avoid it. The already existing `install-jdk.sh` should be able to install JDKs side by side I believe, or is it not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1066813745
We are green. Given how hard it is to get green status from all our CI builders, I'd rather merge than do some other changes (like _remove the "Compile with JDK-11 and test something on JDK-8 " job_) which I've forgotten - they can be done any time later.
By merging this PR we shall be ready to start using [alternative modular implementations](http://wiki.apidesign.org/wiki/AlternativeImplementation). E.g. introduce `org.netbeans.modules.xyz.jdk11` with `javac.target=11` providing better integration with JDK-11 where needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065229890
I've noticed earlier that [NetBeans 13 has broken profiler when running on JDK8](https://app.travis-ci.com/github/apache/netbeans/jobs/562936591#L20558). The [933ab50](https://github.com/apache/netbeans/pull/3744/commits/933ab50188b85fa1caefb170f2da340289bb267c) commit shall fix that. Sorry for not catching it earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065173157
I added a few echos to the build to make it easier to quickly check which JDK is in path. It prints it very early so that it is easily to find.
https://github.com/apache/netbeans/pull/3754/files#diff-ef48f302a1dc02030dd4f72d068dd2c51d8c4e27fab06014cd0f7a1ae7cd2fa9R41-R43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065266776
wondering if we can remove the "Compile with JDK-11 and test something on JDK-8 " gh job if this PR makes it in.
I also have to agree with Neil, we should not use two different scripts for downloading JDKs if there is a reasonable way to avoid it. The already existing `install-jdk.sh` should be able to install JDKs side by side I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#discussion_r825690072
##########
File path: nbbuild/travis/ant.sh
##########
@@ -0,0 +1,60 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+function install() {
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
+ chmod a+x install-jdk.sh
+ ./install-jdk.sh --feature 11 --license GPL --target travisbuildjdk
+}
+
+function download() {
Review comment:
There was a discussion whether using `install-jdk.sh` is better than manual download from a fixed URL. I changed the code to use `install-jdk.sh`, but I still prefer the _fixed URL approach_ a bit more:
- `install-jdk.sh` script may (and should, that's the whole point) change over time - e.g. the download may not always be the same
- fixed URL (plus checksum) is really _fixed_. If you trust the URL provider (I trust Azul to keep it unchanged)...
- anyway for purposes of running CI before integration the difference isn't huge either way
As such I have switched to `install-jdk.sh` but left the original `download` function in the code, not called right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#discussion_r825696102
##########
File path: .travis.yml
##########
@@ -76,29 +76,30 @@ matrix:
env:
- ANT_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false"
script:
- - ant -quiet build-source-config -Dcluster.config=platform
+ - nbbuild/travis/ant.sh -quiet build-source-config -Dcluster.config=platform
- mkdir tmpplatform
- cd tmpplatform
- unzip -qq ../nbbuild/build/platform-src*
- - ant build -Dcluster.config=platform
+ - chmod a+x nbbuild/travis/ant.sh
+ - nbbuild/travis/ant.sh build -Dcluster.config=platform
- - name: Compile all modules with OpenJDK8
+ - name: Compile all modules & tests
Review comment:
Now the job compiles the code and the tests with JDK-11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1063986687
Can we not consolidate on one method of downloading a JDK in this? `install-jdk.sh` should also be in the path and not need downloading itself, although that also may not be the best option. _A_ JDK 11 should also be installed already too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#discussion_r825679026
##########
File path: nbbuild/travis/ant.sh
##########
@@ -0,0 +1,60 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+function install() {
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
+ chmod a+x install-jdk.sh
+ ./install-jdk.sh --feature 11 --license GPL --target travisbuildjdk
+}
+
+function download() {
Review comment:
This function is not called at the moment - leftover, or rather retained alternative support ?
##########
File path: nbbuild/travis/ant.sh
##########
@@ -0,0 +1,60 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+function install() {
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
+ chmod a+x install-jdk.sh
+ ./install-jdk.sh --feature 11 --license GPL --target travisbuildjdk
+}
+
+function download() {
+ JDKURL=https://cdn.azul.com/zulu/bin/zulu11.37.17-ca-jdk11.0.6-linux_x64.zip
+ JDKSHA=0038707cd44ae1d3f535b20aab35e3cf7286371c0c7644e5d7392b52f45caa0a
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ echo Downloading Java from $JDKURL
+ curl -s $JDKURL -o travisbuildjdk.zip
+ SUM=`sha256sum travisbuildjdk.zip | cut -f 1 -d " "`
+ echo SHA-256: $SUM
+ if [ "$SUM" != "$JDKSHA" ]; then
+ echo Expecting $JDKSHA
+ exit 1
+ fi
+ unzip -q travisbuildjdk.zip
+ mv zulu*jdk*linux* travisbuildjdk
+}
+
+AT=`pwd`
+if ! `pwd`/nbbuild/travisbuildjdk/bin/java -version >/dev/null 2>/dev/null; then
+ # download
+ install
+ cd travisbuildjdk
+ echo Java is ready in `pwd`
+ ./bin/java -version
+fi
+cd "$AT"
+
+echo Running ant -q $* at `pwd`
+JAVA_HOME=`pwd`/nbbuild/travisbuildjdk/ ant -q $*
Review comment:
Wouldn't it be safer to add the JDK bin to PATH as well, just in case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#discussion_r825684756
##########
File path: nbbuild/travis/ant.sh
##########
@@ -0,0 +1,60 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+function install() {
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
+ chmod a+x install-jdk.sh
+ ./install-jdk.sh --feature 11 --license GPL --target travisbuildjdk
+}
+
+function download() {
+ JDKURL=https://cdn.azul.com/zulu/bin/zulu11.37.17-ca-jdk11.0.6-linux_x64.zip
+ JDKSHA=0038707cd44ae1d3f535b20aab35e3cf7286371c0c7644e5d7392b52f45caa0a
+ mkdir -p nbbuild/
+ cd nbbuild/
+ rm -rf travisbuildjdk*
+ echo Downloading Java from $JDKURL
+ curl -s $JDKURL -o travisbuildjdk.zip
+ SUM=`sha256sum travisbuildjdk.zip | cut -f 1 -d " "`
+ echo SHA-256: $SUM
+ if [ "$SUM" != "$JDKSHA" ]; then
+ echo Expecting $JDKSHA
+ exit 1
+ fi
+ unzip -q travisbuildjdk.zip
+ mv zulu*jdk*linux* travisbuildjdk
+}
+
+AT=`pwd`
+if ! `pwd`/nbbuild/travisbuildjdk/bin/java -version >/dev/null 2>/dev/null; then
+ # download
+ install
+ cd travisbuildjdk
+ echo Java is ready in `pwd`
+ ./bin/java -version
+fi
+cd "$AT"
+
+echo Running ant -q $* at `pwd`
+JAVA_HOME=`pwd`/nbbuild/travisbuildjdk/ ant -q $*
Review comment:
I am trying to make the use of the downloaded JDK "self-contained". The goal is to limit influence on the rest of the `.travis.yml` operations. True, changing the `PATH` should not affect the "self-containment". The change would only be visible inside the `ant.sh` script.
But the gates are running fine with `JAVA_HOME` - there doesn't seem to be any need to mangle `PATH`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065171058
It wasn't an argument for or against `install-jdk.sh`. It was an argument for picking _one_ way to do this. We're already using it - eg. https://github.com/apache/netbeans/blob/master/.travis.yml#L445
> I wanted to avoid modifying the behavior of the Travis scripts. For example by accidentally switching to JDK11 for testing.
Understand argument for known JDK. But don't see why there's more chance of accidentally switching from using `JAVA_HOME` with the already installed JDKs vs one downloaded. Either way, had wondered merit of running `ant -diagnostics` on each switch of JDK for sanity checking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1064775267
> Can we not consolidate on one method of downloading a JDK in this?
If one trusts that the URL remains persistent, downloading from a URL seems acceptable to me. I have decided to trust this JDK provider in my projects. Moreover this primitive technique is portable across CI types - it shall work everywhere `curl` is installed.
> `install-jdk.sh` should also be in the path and not need downloading itself, although that also may not be the best option.
I've never used it myself. Neither inside Travis, neither locally (e.g. I cannot test the behavior). The PR is however open for edits from maintainers, if users of `install-jdk.sh` want to step in.
> _A_ JDK 11 should also be installed already too.
I wanted to avoid modifying the behavior of the Travis scripts. For example by accidentally switching to JDK11 for testing. Downloading a JDK into temporary directory and using it only in `ant.sh` guarantees no other part of the scripts is going to be influenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1066406572
Looks like [we are green](https://app.travis-ci.com/github/apache/netbeans/jobs/563149156). I squash the changes, accommodate #3778 and then we can review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065266776
wondering if we can remove the "Compile with JDK-11 and test something on JDK-8 " gh job if this PR makes it in.
I also have to agree with Neil, we should not use two different scripts for downloading JDKs if there is a reasonable way to avoid it. install-jdk.sh should be able to install JDKs side by side I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3744: Build with JDK-11 in all Travis jobs
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1065171058
It wasn't an argument for or against `install-jdk.sh`. It was an argument for picking _one_ way to do this. We're already using it - eg. https://github.com/apache/netbeans/blob/master/.travis.yml#L445
> I wanted to avoid modifying the behavior of the Travis scripts. For example by accidentally switching to JDK11 for testing.
Understand argument for known JDK. But don't see why there's any chance of accidentally switching from using `JAVA_HOME` with the already installed JDKs vs one downloaded. Either way, had wondered merit of running `ant -diagnostics` on each switch of JDK for sanity checking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists