You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2015/02/11 12:49:11 UTC
[jira] [Reopened] (SSHD-401) Allow user control over ScpCommand
send/receive buffer size
[ https://issues.apache.org/jira/browse/SSHD-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reopened SSHD-401:
----------------------------------
Now that I think about it, I wonder if a better way would be to pass customisation parameters through the FactoryManager.
If a command implements SessionAware, it will receive the session that can be used to retrieve the FactoryManager and access all custom parameters.
It would seem a bit cleaner to me, thoughts ?
> Allow user control over ScpCommand send/receive buffer size
> -----------------------------------------------------------
>
> Key: SSHD-401
> URL: https://issues.apache.org/jira/browse/SSHD-401
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Goldstein Lyor
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: SSHD-395-to-401.diff
>
>
> While 8192 is a good rule-of-thumb value for I/O buffering, IMO we should allow users to fine-tune it to their needs. Attached is a patch suggestion. *Note*: the patch also optimizes the allocated I/O buffer by taking into consideration the *size* of the file it is expecting to send/receive
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)