You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2016/11/02 02:23:27 UTC
[2/6] hbase git commit: HBASE-16980 TestRowProcessorEndpoint failing
consistently (Yu Li)
HBASE-16980 TestRowProcessorEndpoint failing consistently (Yu Li)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/961b9521
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/961b9521
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/961b9521
Branch: refs/heads/branch-1
Commit: 961b95217136c6fa41892eec693576ad3da113f9
Parents: 6113f9a
Author: Andrew Purtell <ap...@apache.org>
Authored: Tue Nov 1 19:09:17 2016 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Tue Nov 1 19:09:17 2016 -0700
----------------------------------------------------------------------
.../coprocessor/TestRowProcessorEndpoint.java | 23 +++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/961b9521/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
index 12aaa45..9cdf087 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
@@ -183,8 +183,11 @@ public class TestRowProcessorEndpoint {
Get get = new Get(ROW);
LOG.debug("row keyvalues:" + stringifyKvs(table.get(get).listCells()));
int finalCounter = incrementCounter(table);
- assertEquals(numThreads + 1, finalCounter);
- assertEquals(0, failures.get());
+ int failureNumber = failures.get();
+ if (failureNumber > 0) {
+ LOG.debug("We failed " + failureNumber + " times during test");
+ }
+ assertEquals(numThreads + 1 - failureNumber, finalCounter);
}
class IncrementRunner implements Runnable {
@@ -193,6 +196,7 @@ public class TestRowProcessorEndpoint {
try {
incrementCounter(table);
} catch (Throwable e) {
+ failures.incrementAndGet();
e.printStackTrace();
}
}
@@ -245,9 +249,17 @@ public class TestRowProcessorEndpoint {
stringifyKvs(table.get(new Get(ROW)).listCells()));
LOG.debug("row2 keyvalues:" +
stringifyKvs(table.get(new Get(ROW2)).listCells()));
- assertEquals(rowSize, table.get(new Get(ROW)).listCells().size());
- assertEquals(row2Size, table.get(new Get(ROW2)).listCells().size());
- assertEquals(0, failures.get());
+ int failureNumber = failures.get();
+ if (failureNumber > 0) {
+ LOG.debug("We failed " + failureNumber + " times during test");
+ }
+ if (!swapped) {
+ assertEquals(rowSize, table.get(new Get(ROW)).listCells().size());
+ assertEquals(row2Size, table.get(new Get(ROW2)).listCells().size());
+ } else {
+ assertEquals(rowSize, table.get(new Get(ROW2)).listCells().size());
+ assertEquals(row2Size, table.get(new Get(ROW)).listCells().size());
+ }
}
class SwapRowsRunner implements Runnable {
@@ -256,6 +268,7 @@ public class TestRowProcessorEndpoint {
try {
swapRows(table);
} catch (Throwable e) {
+ failures.incrementAndGet();
e.printStackTrace();
}
}