You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "cstruct (via GitHub)" <gi...@apache.org> on 2025/07/29 17:02:05 UTC
[PR] chore: Add hk git hook manager [iggy]
cstruct opened a new pull request, #2055:
URL: https://github.com/apache/iggy/pull/2055
This adds [hk](hk.jdx.dev) as a git hook manager and configures it to run for all Rust projects in `core/` as well as `foreign/python`.
This is meant as a proposal for adding a git hook manager in general and I am not married to the idea that it has to be `hk` or done in any specific way.
`hk` was chosen because of monorepo support and its use of `pkl` lang for configuration allowing powerful generation of the config.
Hooks for each foreign SDK besides Python remains to be implemented.
One open question is whether one wants steps for dependents to run on changes? i.e. If `core/common` is changed do we want to run tests for `core/sdk`?
Hopefully other feel this would be a useful addition too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(repo): add hk git hook manager [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2055:
URL: https://github.com/apache/iggy/pull/2055#issuecomment-3569740948
HK requires Java and pkl. We decided to use `prek` - github.com/apache/iggy/pull/2383.
@cstruct I hope it's fine for you 🦀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add hk git hook manager [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2055:
URL: https://github.com/apache/iggy/pull/2055#issuecomment-3180110042
I like what you presented here.. Let's work on this after #2101 - I added plenty of new checks and we could incorporate them all at once into your `pkl` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(repo): add hk git hook manager [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed pull request #2055: chore(repo): add hk git hook manager
URL: https://github.com/apache/iggy/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org