You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/25 18:47:42 UTC

[GitHub] [accumulo] foster33 opened a new pull request, #2734: Remove TODOs and rename PerTableVolumeChooser

foster33 opened a new pull request, #2734:
URL: https://github.com/apache/accumulo/pull/2734

   Addresses #2699 
   
   This PR addresses the following:
   
   - Removal of some of the TODOs throughout the code. 
   - Changes the name of `PerTableVolumeChooser` to `DelegatingChooser` where needed.
   - Renames `PerTableVolumeChooser.java` to `DelegatingChooser.java`
   - Fixes a grammatical error addressed in original issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #2734: Remove TODOs and rename PerTableVolumeChooser

Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #2734:
URL: https://github.com/apache/accumulo/pull/2734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] foster33 commented on pull request #2734: Remove TODOs and rename PerTableVolumeChooser

Posted by GitBox <gi...@apache.org>.
foster33 commented on PR #2734:
URL: https://github.com/apache/accumulo/pull/2734#issuecomment-1137723870

   When going through and changing `PerTableVolumeChooser` to `DelegatingChooser`, I noticed that there was a test that seemed to be focused on the `PerTableVolumeChooser` named `PerTableVolumeChooserTest`.
   
   Since `PerTableVolumeChooser` has now been renamed to `DelegatingChooser`, is there now a need to change the name of that testing file as well? For example, renaming it to `DelegatingChooserTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org