You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/05/22 12:56:16 UTC

[kudu-CR] hms: Adjust external table handling

Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13347

to look at the new patch set (#6).

Change subject: hms:  Adjust external table handling
......................................................................

hms:  Adjust external table handling

This patch changes the handling of external HMS tables.
Currently we synchronize external HMS entries and
create all synchronized HMS entries as external.

With this patch, we only synchronize managed HMS
entries and create all entries as managed by default.
This allows external tables to work the same regardless
of HMS synchronization being enabled.

This patch touches many locations in the code because
the use and validation of the new behavior is tightly
coupled.

The changes include:
- Prevent altering table type via the KuduMetastorePlugin
- Ignore non-managed Kudu tables in the
  KuduMetastorePlugin
- Ignore non-managed Kudu tables in the
  hms_notification_log_listener
- Use managed tables by default
- Always use the new storage format for new entries
- Add the table_name property to the new storage format
- Adjust upgrade and downgrade logic for external tables
- Adjust  HmsCatalog::PopulateTable logic for external
  tables
- Adjust the tooling logic to correctly handle external
  tables.

Note: The updates to tooling logic and testing was
minimal and will be improved in follow on patches.

Change-Id: I6b7495486fa86710afb670a8e12f72684ba7af8f
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
14 files changed, 386 insertions(+), 205 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/13347/6
-- 
To view, visit http://gerrit.cloudera.org:8080/13347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b7495486fa86710afb670a8e12f72684ba7af8f
Gerrit-Change-Number: 13347
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)