[GitHub] [calcite] julianhyde commented on a change in pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

[GitBox <gi...@apache.org>]

julianhyde commented on a change in pull request #2271:
URL: https://github.com/apache/calcite/pull/2271#discussion_r526469745



##########
File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -2186,6 +2186,13 @@ protected static Calendar getCalendarNotTooNear(int timeUnit) {
     checkConcat2Func(tester(SqlLibrary.ORACLE));
   }
 
+  @Test void testSubString() {

Review comment:
       It looks as if this function was never tested. Thanks for fixing the hole.
   
   Rename the test method to `testOracleSubstrFunction` and move it next to `testSubstringFunction`.
   
   Test a few more cases - e.g. indexes out of bounds, and null values, and CHAR argument.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org