You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/11/02 11:11:38 UTC

[GitHub] [cordova-lib] raphinesse commented on a change in pull request #888: dep(dev)!: bump @cordova/eslint-config@^4.0.0 w/ fix

raphinesse commented on a change in pull request #888:
URL: https://github.com/apache/cordova-lib/pull/888#discussion_r740949210



##########
File path: spec/cordova/plugin/remove.spec.js
##########
@@ -32,8 +32,7 @@ describe('cordova/plugin/remove', function () {
     const cfg_parser_mock = function () {};
     let package_json_mock;
     const plugin_info_provider_mock = function () {};
-    let plugin_info;
-    package_json_mock = jasmine.createSpyObj('package json mock', ['cordova', 'dependencies']);
+    const plugin_info = jasmine.createSpyObj('package json mock', ['cordova', 'dependencies']);

Review comment:
       Should be `package_json_mock = ...`, right?

##########
File path: spec/plugman/util/metadata.spec.js
##########
@@ -32,6 +32,7 @@ const fsMock = {
 };
 
 // expect fsMock to only operate on fetchJsonPath
+// eslint-disable-next-line
 Object.entries(fsMock).map(([key, fn]) => {

Review comment:
       Would `forEach` work without a warning?
   ```js
   Object.entries(fsMock).forEach(([key, fn]) => {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org