You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by jc...@apache.org on 2016/11/14 19:02:21 UTC
cordova-plugin-inappbrowser git commit: fix(close button): Set
correct content description
Repository: cordova-plugin-inappbrowser
Updated Branches:
refs/heads/master 5cbbc8e26 -> 1b4859c17
fix(close button): Set correct content description
This closes #196
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/1b4859c1
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/1b4859c1
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/1b4859c1
Branch: refs/heads/master
Commit: 1b4859c17520fc3637e0854c260539c7a7858c78
Parents: 5cbbc8e
Author: Philippe Morier <th...@outlook.com>
Authored: Fri Oct 28 15:21:08 2016 +0100
Committer: Julio C�sar <jc...@gmail.com>
Committed: Mon Nov 14 20:01:48 2016 +0100
----------------------------------------------------------------------
src/android/InAppBrowser.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/1b4859c1/src/android/InAppBrowser.java
----------------------------------------------------------------------
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index b54c224..07ac31e 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -688,7 +688,7 @@ public class InAppBrowser extends CordovaPlugin {
RelativeLayout.LayoutParams closeLayoutParams = new RelativeLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.MATCH_PARENT);
closeLayoutParams.addRule(RelativeLayout.ALIGN_PARENT_RIGHT);
close.setLayoutParams(closeLayoutParams);
- forward.setContentDescription("Close Button");
+ close.setContentDescription("Close Button");
close.setId(Integer.valueOf(5));
int closeResId = activityRes.getIdentifier("ic_action_remove", "drawable", cordova.getActivity().getPackageName());
Drawable closeIcon = activityRes.getDrawable(closeResId);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org