[GitHub] [iceberg] rdblue commented on a change in pull request #1530: Spark: Implement equals and hashCode in SparkTable

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1530:
URL: https://github.com/apache/iceberg/pull/1530#discussion_r498391608



##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java
##########
@@ -525,6 +525,34 @@ public void testVersionHintFileMissingMetadata() throws Exception {
         () -> TABLES.load(tableLocation));
   }
 
+  @Test
+  public void testTableEquality() throws Exception {

Review comment:
       I think implementing `toString` is a good practice. Spark uses it in query plans quite a bit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org