[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #2218:
URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234962972


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -427,7 +436,7 @@ private void updateKeysIndex(WriteBatch batch, byte[] key, long curRev) {
      * @throws RocksDBException If failed.
      */
     private void fillAndWriteBatch(WriteBatch batch, long newRev, long newCntr, @Nullable HybridTimestamp ts) throws RocksDBException {
-        try (WriteOptions opts = new WriteOptions()) {
+        try (WriteOptions opts = new WriteOptions().setDisableWAL(true)) {

Review Comment:
   Sure



##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -239,20 +243,25 @@ public void start() {
     }
 
     private static List<ColumnFamilyDescriptor> cfDescriptors() {
-        Options dataOptions = new Options().setCreateIfMissing(true)
+        Options sharedOptions = new Options()

Review Comment:
   "baseOptions", thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org