You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "dombizita (via GitHub)" <gi...@apache.org> on 2023/03/30 07:25:00 UTC
[GitHub] [ozone] dombizita opened a new pull request, #4500: HDDS-8239. RATIS_DATASTREAM port compatibility issue
dombizita opened a new pull request, #4500:
URL: https://github.com/apache/ozone/pull/4500
## What changes were proposed in this pull request?
Based on previous discussions we found out that the `RATIS_DATASTREAM` port in `DatanodeDetails` suffers from incompatibility problem and we decided to add a HDDS layout version as `RATIS_DATASTREAM_PORT_IN_DATANODEDETAILS` to handle that. I created a `BelongsToHDDSLayoutVersion` annotation and used it to annotate the `RATIS_DATASTREAM` port with it. In the `getDatanodeDetailsYaml()` when we are adding the ports I checked if the port has this annotation and checked if the current layout version is smaller than the layout version of the annotation. In that case I am not writing the ports in to the DatanodeDetails yaml file.
As not the `DATANODE_SCHEMA_V3` is the latest HDDS layout version anymore I changed some tests to not require exact match with the versions in the `TestDatanodeUpgradeToSchemaV3`.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8239
## How was this patch tested?
CI on my fork: https://github.com/dombizita/ozone/actions/runs/4558939757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4500: HDDS-8239. RATIS_DATASTREAM port compatibility issue
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4500:
URL: https://github.com/apache/ozone/pull/4500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org