You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by lyonplus <gi...@git.apache.org> on 2014/09/24 17:38:25 UTC
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
GitHub user lyonplus opened a pull request:
https://github.com/apache/cordova-ios/pull/106
Remove duplicate reference to the same libCordova.a.
libCordova.a has already been referred to as a framework, no need to
force_load it again.
Normally it is OK to refer to libCordova.a twice, as they are the same
file anyway. But when symbolic link is used in workspace and Jenkins is
use to do the build, there will be a problem because Jenkins will
dereference symbolic links (https://issues.jenkins-ci.org/browse/JENKINS-5597)
and now we could have 2 copies of libCordova.a, and have countless
duplicate symbols errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lyonplus/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit bf6a1bc24d604eb7db113afd6bf9af8701ca076f
Author: Lianghui Chen <li...@blackberry.com>
Date: 2014-09-22T19:24:58Z
Remove duplicate reference to the same libCordova.a.
libCordova.a has already been referred to as a framework, no need to
force_load it again.
Normally it is OK to refer to libCordova.a twice, as they are the same
file anyway. But when symbolic link is used in workspace and Jenkins is
use to do the build, there will be a problem because Jenkins will
dereference symbolic links (https://issues.jenkins-ci.org/browse/JENKINS-5597)
and now we could have 2 copies of libCordova.a, and have countless
duplicate symbols errors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Posted by lyonplus <gi...@git.apache.org>.
Github user lyonplus commented on the pull request:
https://github.com/apache/cordova-ios/pull/106#issuecomment-56726607
shazron: thanks so much and sorry for not having done it myself!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Posted by lyonplus <gi...@git.apache.org>.
Github user lyonplus commented on the pull request:
https://github.com/apache/cordova-ios/pull/106#issuecomment-57595003
Thanks for all the hardworking, shazron!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894
Per CONTRIBUTING.md, a JIRA issue should have been filed. I have filed it for you: https://issues.apache.org/jira/browse/CB-7627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Posted by lyonplus <gi...@git.apache.org>.
Github user lyonplus closed the pull request at:
https://github.com/apache/cordova-ios/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/106#issuecomment-57590952
Thanks! Tested and pulled in. https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=2ba35b1
You can close this PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---