You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/16 19:16:02 UTC
[GitHub] graceguo-supercat commented on a change in pull request #5329:
[Table Viz] Table columns not match with group_by control
graceguo-supercat commented on a change in pull request #5329: [Table Viz] Table columns not match with group_by control
URL: https://github.com/apache/incubator-superset/pull/5329#discussion_r202793131
##########
File path: superset/viz.py
##########
@@ -509,7 +509,7 @@ def query_obj(self):
'Choose either fields to [Group By] and [Metrics] or '
'[Columns], not both'))
- sort_by = fd.get('timeseries_limit_metric') or []
+ sort_by = fd.get('timeseries_limit_metric') or None
Review comment:
fixed. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org