You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/21 07:15:43 UTC

[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #5041: Fix typos in comments and Kconfig files

juniskane commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772881018



##########
File path: sched/Kconfig
##########
@@ -13,14 +13,6 @@ menuconfig DISABLE_OS_API
 		disable functions unless you want to restrict usage
 		of those APIs.
 
-		There are certain dependency relationships in these
-		features.
-
-		1) mq_notify logic depends on signals to awaken tasks
-		waiting for queues to become full or empty.
-		2) pthread_condtimedwait() depends on signals to wake
-		up waiting tasks.
-

Review comment:
       That section was meaningful only when we had CONFIG_DISABLE_SIGNALS. Makes little sense to list dependencies to features that cannot in fact be removed. Wording "in these features" refers to the set of features than can be disabled by subitems of CONFIG_DISABLE_OS_API so it is misleading to imply that signals are part of it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org