[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #297: [YUNIKORN-791] Allow to register nodes with infinite resources

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #297:
URL: https://github.com/apache/incubator-yunikorn-core/pull/297#discussion_r691114541



##########
File path: pkg/scheduler/context.go
##########
@@ -844,3 +888,16 @@ func (cc *ClusterContext) GetNode(nodeID, partitionName string) *objects.Node {
 	}
 	return partition.GetNode(nodeID)
 }
+
+func (cc *ClusterContext) checkForUnlimitedNodes() bool {

Review comment:
       We need to check for unlimited nodes cluster wide, no? If we moove it per partition, we might have an unlimited node in some other partition, than the onee we are checking. Is this acceptable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org