Re: svn commit: rev 5380 - trunk/subversion/tests/clients/cmdline

[Greg Stein <gs...@lyra.org>]

On Tue, Mar 18, 2003 at 03:56:27PM -0600, kraai@tigris.org wrote:
>...
> +++ trunk/subversion/tests/clients/cmdline/getopt_tests.py	Tue Mar 18 15:56:09 2003
>...
> @@ -123,7 +121,7 @@
>      print "====="
>      map(sys.stdout.write, actual_stdout)
>      print "====="
> -    return 1
> +    raise svntest.Failure

This should have its own svntest.Failure subclass.

>    if exp_stderr != actual_stderr:
>      print "Standard error does not match."
> @@ -135,41 +133,39 @@
>      print "====="
>      map(sys.stdout.write, actual_stderr)
>      print "====="
> -    return 1
> -
> -  return 0
> +    raise svntest.Failure

Ditto.

>  def getopt_no_args(sbox):
>    "run svn with no arguments"
> -  return run_one_test(sbox, 'svn')
> +  run_one_test(sbox, 'svn')

Good! See, these functions now have less work since they don't have to deal
with returning a value.

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org