[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #14254: [Improvement][Metrics] Add more worker related metrics and fix some previous ones

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #14254:
URL: https://github.com/apache/dolphinscheduler/pull/14254#discussion_r1212701893


##########
docs/docs/en/guide/metrics/metrics.md:
##########
@@ -104,6 +103,12 @@ For example, you can get the master metrics by `curl http://localhost:5679/actua
 ### Worker Server Metrics
 
 - ds.worker.overload.count: (counter) the number of times the worker overloaded
+- ds.worker.task: (gauge) the number of tasks on the worker, including pending and running ones
+- ds.worker.execute.queue.size: (gauge) the number of pending tasks on the worker
+- ds.worker.active.execute.thread: (gauge) the number of running tasks on the worker
+- ds.worker.memory.available: (gauge) the available physical memory of the worker

Review Comment:
   Can we add the unit to the doc? 
   ```suggestion
   - ds.worker.memory.available: (gauge) the available physical memory (in bytes?) of the worker
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org