You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/06 02:49:41 UTC

Review Request: FLUME-1818. Add layout support to log4jappender.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Added layout support to log4jappender.


This addresses bug FLUME-1818.
    https://issues.apache.org/jira/browse/FLUME-1818


Diffs
-----

  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 

Diff: https://reviews.apache.org/r/8845/diff/


Testing
-------

Existing tests pass, added new test to test this feature.


Thanks,

Hari Shreedharan

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Hari Shreedharan <hs...@cloudera.com>.

> On Jan. 14, 2013, 5:35 p.m., Brock Noland wrote:
> > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java, line 137
> > <https://reviews.apache.org/r/8845/diff/2/?file=245105#file245105line137>
> >
> >     We are just testing the layout functionality, correct? If so then only need to send a few events through?

Yeah, I will drop it down to like 100 events.


> On Jan. 14, 2013, 5:35 p.m., Brock Noland wrote:
> > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java, line 138
> > <https://reviews.apache.org/r/8845/diff/2/?file=245105#file245105line138>
> >
> >     Would it be possible to get a comment or two as to what is going on with regards to the "level" variable?

Yes, I will add a comment there. But this is basically because Log4j defines values for levels as:

  public final static int OFF_INT = Integer.MAX_VALUE;
  public final static int FATAL_INT = 50000;
  public final static int ERROR_INT = 40000;
  public final static int WARN_INT  = 30000;
  public final static int INFO_INT  = 20000;
  public final static int DEBUG_INT = 10000;

So unless we have levels as mutliples of 10000, it falls to the default, which I think is DEBUG


- Hari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15316
-----------------------------------------------------------


On Jan. 6, 2013, 2:38 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 2:38 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15316
-----------------------------------------------------------


Hari,

Looks good! I don't see any new docs, is this something that should be documented? A few comments below.


flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java
<https://reviews.apache.org/r/8845/#comment32980>

    We are just testing the layout functionality, correct? If so then only need to send a few events through?



flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java
<https://reviews.apache.org/r/8845/#comment32979>

    Would it be possible to get a comment or two as to what is going on with regards to the "level" variable?


- Brock Noland


On Jan. 6, 2013, 2:38 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 2:38 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Hari Shreedharan <hs...@cloudera.com>.

> On Jan. 14, 2013, 7:51 p.m., Brock Noland wrote:
> > Looks the patch was updated but I don't see it on the JIRA?

Done.


- Hari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15324
-----------------------------------------------------------


On Jan. 14, 2013, 7:35 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 7:35 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15324
-----------------------------------------------------------


Looks the patch was updated but I don't see it on the JIRA?

- Brock Noland


On Jan. 14, 2013, 7:35 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 7:35 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15330
-----------------------------------------------------------

Ship it!


- Brock Noland


On Jan. 14, 2013, 7:35 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 7:35 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/#review15329
-----------------------------------------------------------

Ship it!


- Brock Noland


On Jan. 14, 2013, 7:35 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8845/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 7:35 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added layout support to log4jappender.
> 
> 
> This addresses bug FLUME-1818.
>     https://issues.apache.org/jira/browse/FLUME-1818
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 
> 
> Diff: https://reviews.apache.org/r/8845/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass, added new test to test this feature.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 7:35 p.m.)


Review request for Flume.


Description
-------

Added layout support to log4jappender.


This addresses bug FLUME-1818.
    https://issues.apache.org/jira/browse/FLUME-1818


Diffs (updated)
-----

  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 

Diff: https://reviews.apache.org/r/8845/diff/


Testing
-------

Existing tests pass, added new test to test this feature.


Thanks,

Hari Shreedharan

Re: Review Request: FLUME-1818. Add layout support to log4jappender.

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8845/
-----------------------------------------------------------

(Updated Jan. 6, 2013, 2:38 a.m.)


Review request for Flume.


Changes
-------

Updated unit tests to make sure different logging levels are actually used (since log4j levels are multiples of 10000).


Description
-------

Added layout support to log4jappender.


This addresses bug FLUME-1818.
    https://issues.apache.org/jira/browse/FLUME-1818


Diffs (updated)
-----

  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 68d95fb 

Diff: https://reviews.apache.org/r/8845/diff/


Testing
-------

Existing tests pass, added new test to test this feature.


Thanks,

Hari Shreedharan