You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 04:20:41 UTC

[GitHub] [arrow] projjal opened a new pull request #8742: ARROW-10690: [Java] Fix ComplexCopier bug for list vector

projjal opened a new pull request #8742:
URL: https://github.com/apache/arrow/pull/8742


   ComplexCopier gives incorrect result for list vector if target vector is non-empty. When copying a list vector using ComplexCopier, if the target list vector is non-empty, the result vector is incorrect. For example, if src = [[1,2], [3, 4]], tgt = [[5, 6], [7, 8]], copying src to tgt gives tgt = [[5, 6, 1, 2], [3, 4]] instead of [[1,2], [3, 4]]
   Similary when using copyFrom(/Safe) method if the vector at the index is non-empty, the listElement is appended instead. For above src and tgt vector, tgt.copyFrom(0, 0, src) gives [[5, 6, 1, 2], []] instead of [[1,2], [3, 4]]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] praveenbingo closed pull request #8742: ARROW-10690: [Java] Fix ComplexCopier bug for list vector

Posted by GitBox <gi...@apache.org>.
praveenbingo closed pull request #8742:
URL: https://github.com/apache/arrow/pull/8742


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] liyafan82 commented on pull request #8742: ARROW-10690: [Java] Fix ComplexCopier bug for list vector

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #8742:
URL: https://github.com/apache/arrow/pull/8742#issuecomment-732650950


   For the second example in the discussion, the result should be [[1, 2], [7, 8]]?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8742: ARROW-10690: [Java] Fix ComplexCopier bug for list vector

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8742:
URL: https://github.com/apache/arrow/pull/8742#issuecomment-731919456


   https://issues.apache.org/jira/browse/ARROW-10690


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] projjal commented on pull request #8742: ARROW-10690: [Java] Fix ComplexCopier bug for list vector

Posted by GitBox <gi...@apache.org>.
projjal commented on pull request #8742:
URL: https://github.com/apache/arrow/pull/8742#issuecomment-732680926


   > For the second example in the discussion, the result should be [[1, 2], [7, 8]]?
   
   You are right. I miswrote that part. Updated the description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org