You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "AtkinsChang (via GitHub)" <gi...@apache.org> on 2023/03/25 02:27:44 UTC

[GitHub] [pulsar-helm-chart] AtkinsChang opened a new pull request, #355: Changed `publishNotReadyAddresses` to service spec from annotation

AtkinsChang opened a new pull request, #355:
URL: https://github.com/apache/pulsar-helm-chart/pull/355

   Same as apache#64 but for Zookeeper.
   
   ### Motivation
   
   - `publishNotReadyAddresses` is a service spec and not a service annotation. This is mentioned in the K8s API docs at https://v1-17.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#servicespec-v1-core
   
   ### Modifications
   
   - Modified `publishNotReadyAddresses` from annotation to service spec
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #355: Changed `publishNotReadyAddresses` to service spec from annotation

Posted by "lhotari (via GitHub)" <gi...@apache.org>.

lhotari commented on PR #355:
URL: https://github.com/apache/pulsar-helm-chart/pull/355#issuecomment-1632735587

   Thanks for the PR. I made `publishNotReadyAddresses` always appear for Zookeeper STS as part of fixing the CI tests. I'm closing this PR since it won't be needed anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari closed pull request #355: Changed `publishNotReadyAddresses` to service spec from annotation

Posted by "lhotari (via GitHub)" <gi...@apache.org>.

lhotari closed pull request #355: Changed `publishNotReadyAddresses` to service spec from annotation
URL: https://github.com/apache/pulsar-helm-chart/pull/355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org