You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/16 04:49:37 UTC
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2493: [INLONG-2483] Manager provide metadata interface to Dataproxy, and Dataproxy dynamically get metadata and MQ config from Manager.
healchow commented on a change in pull request #2493:
URL: https://github.com/apache/incubator-inlong/pull/2493#discussion_r807524366
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/PulsarClusterEntity.java
##########
@@ -19,13 +19,14 @@
import lombok.Data;
-/**
- * DataProxy config
- */
+import java.io.Serializable;
+
@Data
-public class DataProxyConfig {
+public class PulsarClusterEntity implements Serializable {
Review comment:
Reuse the `ClusterInfoEntity`.
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/ProxyPulsarMapEntity.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class ProxyPulsarMapEntity implements Serializable {
+ private static final long serialVersionUID = 1L;
+ private Integer id;
+ private String proxyClusterName;
+ private String pulsarSetName;
+ private String inlongGroupId;
Review comment:
Remove this field, and add `proxyClusterId` into `BusinessEntity`.
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/ProxyPulsarMapEntity.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class ProxyPulsarMapEntity implements Serializable {
Review comment:
Reuse the `DataProxyClusterEntity`.
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/PulsarConfigEntity.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class PulsarConfigEntity implements Serializable {
Review comment:
Reuse the `ClusterInfoEntity`.
##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/ProxyPulsarMapEntity.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class ProxyPulsarMapEntity implements Serializable {
+ private static final long serialVersionUID = 1L;
+ private Integer id;
+ private String proxyClusterName;
+ private String pulsarSetName;
Review comment:
Change it to `mqSetName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org