You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/06/02 19:00:58 UTC
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17534
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
[consensus] --evict_failed_followers is a runtime flag
Current implementation of Raft consensus treats --evict_failed_followers
as a runtime flag. This patch adds corresponding tag for the flag.
Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Reviewed-on: http://gerrit.cloudera.org:8080/17522
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit 0a8c84a53b4bbe916f9afca3280eb863840ece2a)
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/17534/1
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has removed a vote on this change.
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17534 )
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
Patch Set 1: Verified+1
Unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Jun 2021 20:33:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17534 )
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:43:51 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17534 )
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
[consensus] --evict_failed_followers is a runtime flag
Current implementation of Raft consensus treats --evict_failed_followers
as a runtime flag. This patch adds corresponding tag for the flag.
Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Reviewed-on: http://gerrit.cloudera.org:8080/17522
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit 0a8c84a53b4bbe916f9afca3280eb863840ece2a)
Reviewed-on: http://gerrit.cloudera.org:8080/17534
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Bankim Bhavsar: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [consensus] --evict failed followers is a runtime flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17534 )
Change subject: [consensus] --evict_failed_followers is a runtime flag
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ff0c4097df72c3a2d43ee166e29af5f67b5687
Gerrit-Change-Number: 17534
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:13:18 +0000
Gerrit-HasComments: No