You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/27 19:08:30 UTC
[GitHub] [superset] eschutho opened a new pull request, #21958: chore: bump pyathena and related packages
eschutho opened a new pull request, #21958:
URL: https://github.com/apache/superset/pull/21958
### SUMMARY
Bumping pyathena and adding in the relevant pandas requirements for that package in order to use the schema `pyathena+pandas` which was introduced in 2.0
### TESTING INSTRUCTIONS
Creating and running dbs with both rest and pandas drivers for pyathena should now work
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1008270890
##########
setup.py:
##########
@@ -120,11 +120,11 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
# needed to support Literal (3.8) and TypeGuard (3.10)
- "typing-extensions>=3.10, <4",
+ "typing-extensions>=4, <5",
Review Comment:
sure thing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho merged pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
eschutho merged PR #21958:
URL: https://github.com/apache/superset/pull/21958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21958:
URL: https://github.com/apache/superset/pull/21958#issuecomment-1294068352
# [Codecov](https://codecov.io/gh/apache/superset/pull/21958?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21958](https://codecov.io/gh/apache/superset/pull/21958?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0394aea) into [master](https://codecov.io/gh/apache/superset/commit/196c3671e279c3c7e3f8644f43017b3f81b707c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (196c367) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21958 +/- ##
==========================================
- Coverage 66.89% 66.89% -0.01%
==========================================
Files 1805 1805
Lines 69055 69117 +62
Branches 7366 7366
==========================================
+ Hits 46197 46237 +40
- Misses 20956 20978 +22
Partials 1902 1902
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.92% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `78.36% <ø> (+0.12%)` | :arrow_up: |
| postgres | `?` | |
| presto | `52.82% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.41% <ø> (-0.04%)` | :arrow_down: |
| sqlite | `76.91% <ø> (+0.12%)` | :arrow_up: |
| unit | `51.09% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.67% <0.00%> (-5.94%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `86.79% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `85.71% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/databases/commands/validate\_sql.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3ZhbGlkYXRlX3NxbC5weQ==) | `92.00% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `92.20% <0.00%> (-1.30%)` | :arrow_down: |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `94.44% <0.00%> (-0.84%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `94.98% <0.00%> (-0.55%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.87% <0.00%> (-0.52%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/21958/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho closed pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #21958: chore: bump pyathena and related packages
URL: https://github.com/apache/superset/pull/21958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007473925
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
The `_` for `-`. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #21958:
URL: https://github.com/apache/superset/pull/21958#issuecomment-1297342440
🏷️ preset:2022.43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007695303
##########
setup.py:
##########
@@ -120,11 +120,11 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
# needed to support Literal (3.8) and TypeGuard (3.10)
- "typing-extensions>=3.10, <4",
+ "typing-extensions>=4, <5",
Review Comment:
Can we add a comment to the description that `typing-extensions` is also bumped in this PR? Also, can you remove the reference to `Literal` on line 122, as we're no longer supporting Python 3.7 or lower (in other words, we currently only need `TypeGuard` from `typing-extensions`)
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
Good catch. Rant: I always cringe at the fact that `-` and `_` can be used interchangeably for Python deps.. 😡
##########
setup.py:
##########
@@ -120,11 +120,11 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
# needed to support Literal (3.8) and TypeGuard (3.10)
- "typing-extensions>=3.10, <4",
+ "typing-extensions>=4, <5",
Review Comment:
Can we add a comment to the PR description that `typing-extensions` is also bumped in this PR? Also, can you remove the reference to `Literal` on line 122, as we're no longer supporting Python 3.7 or lower (in other words, we currently only need `TypeGuard` from `typing-extensions`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #21958:
URL: https://github.com/apache/superset/pull/21958#issuecomment-1293953857
There were some unexpected changes when running pip-compile-multi --no-upgrade on this. It looks like it is updating some of your recent changes [here](https://github.com/apache/superset/commit/640628952e6017a29fbb494754f8a4a967510cb6) @betodealmeida. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007473496
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
Did something change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007473925
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
The `-` for `_`. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #21958: chore: bump pyathena and related packages
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007480842
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
ah good eye
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org