[jira] [Commented] (NIFI-4824) Dockerhub Image - allow user to specific host ports on startup

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342676#comment-16342676 ] 

ASF GitHub Bot commented on NIFI-4824:
--------------------------------------

GitHub user Chaffelson opened a pull request:

    https://github.com/apache/nifi/pull/2439

    NIFI-4824 - Allow user to specific host ports on Docker Image startup

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    No, but that's because one commit is a bug fix, and the other is an enhancement.
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Chaffelson/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2439
    
----
commit 942d128fdd4083e6428055aea6d802577f13136e
Author: dchaffey <dc...@...>
Date:   2018-01-28T18:23:58Z

    Corrected Docker tag back to standard format

commit e0fa94f83ecdf9008f42d25abffb2224e92eaf84
Author: dchaffey <dc...@...>
Date:   2018-01-28T18:46:20Z

    Modified Docker startup scripts to accept Environment variables if available, or use the usual defaults if not.
    Updated readme to reflect changes in allowing environment variables.
    Updated readme to correctly reflect the default ports that NiFi will run on.

----


> Dockerhub Image - allow user to specific host ports on startup
> --------------------------------------------------------------
>
>                 Key: NIFI-4824
>                 URL: https://issues.apache.org/jira/browse/NIFI-4824
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Docker
>    Affects Versions: 1.2.0, 2.0.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0
>            Reporter: Daniel Chaffelson
>            Priority: Critical
>
> As a user of the official apache/nifi Docker image, I would like to be able to easily pass in the ports I want NiFi to start on. This is particularly important since the 1.5.0 release, where remapping ports outside the container cause NiFi to throw a security error.
> This will be particularly useful in NiFI-1.5.0 and newer, where users are often running multiple instances of the same version in order to test Flow Versioning and other new features around the NiFi-Registry project.
> This can be done by slightly modifying the startup scripts included in the package to use an environment variable if available, or a default if it is not provided. It is then very easy to pass an environment variable to the Docker image on startup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)