[GitHub] ThomasDelteil commented on a change in pull request #11210: [MXNET-532] Clarify documentation of save_params(), load_params(), export()

[GitBox <gi...@apache.org>]

ThomasDelteil commented on a change in pull request #11210: [MXNET-532] Clarify documentation of save_params(), load_params(), export()
URL: https://github.com/apache/incubator-mxnet/pull/11210#discussion_r194879113
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -309,6 +309,17 @@ def _collect_params_with_prefix(self, prefix=''):
 
     def save_params(self, filename):
         """Save parameters to file.
+        This function is to be used to save parameters of a Gluon model, note that
+        the saved parameters are not meant to be loaded in a different language binding for now.
+        Saving parameters using `.save_params()` is different than
+        `.collect_params().save()`, which is a deprecated way to save parameters of a model
+        and should be avoided.
 
 Review comment:
   no I don't agree. I think the documentation here is the one that should be moved to save_parameters and load_parameters.
   
   ```
   Saving parameters using `.save_params()` is different than
   +        `.collect_params().save()`, which is a deprecated way to save parameters of a model
   +        and should be avoided.
   ```
   ->
   ```
   Saving parameters using `.save_parameters()` is different than
   +        `.collect_params().save()` and .save_params() which are deprecated ways to save parameters of a model
   +        and should be avoided.
   ```
   Once the other PR is merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services