DO NOT REPLY [Bug 11387] New: - FormTag.method initial value is "POST", not null

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11387>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11387

FormTag.method initial value is "POST", not null

           Summary: FormTag.method initial value is "POST", not null
           Product: Struts
           Version: Nightly Build
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Custom Tags
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: dmkarr@earthlink.net


Craig mentioned he wanted to make sure all initial (and "release"d values) of
tag attributes are null, and only use non-null values on conditional checks in
the tag code.

In the FormTag class, the "method" and "scope" attributes violate this.  The
"method" attribute is initialized to the string "POST" and also set to this in
the "release()" method.  Similarly, the "scope" attribute is initialized to
"session" and set to that in "release()".

The current settings of these are "consistent", in that the resulting
constructed value and "release"d values are the same, but it's cleaner to init
and reset to all null values.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>