You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/02/22 17:04:56 UTC
[GitHub] tinkerpop pull request #562: TINKERPOP-1626: choose() is buggy in OLAP
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/562
TINKERPOP-1626: choose() is buggy in OLAP
https://issues.apache.org/jira/browse/TINKERPOP-1626
`ComputerAwareStep.EndStep` was using `path.extend()` and not `traverser.addLabel()` to append step labels in OLAP and thus, the step label data wasn't being recorded because `path.extend()` is an immutable operation. Also, updated `PathRetractionStrategy` to look like `LazyBarrierStrategy's` recent tweaks to not add a barrier to the end of a traversal -- leave that up to `RemoteStrategy`.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1626
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit 012edf17531f5b4ce979351bdfde504a32437800
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-02-22T16:59:09Z
fixed a bug in OLAP ComputerAwareStep.EndStep where labels were not being appended to the traverser correctly. Also, a small optimization tweak to PathRetractionStrategy to mirror the barrier-optimization retraction that was done earlier on tp32/ around LazyBarrierStrategy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/562
`docker/build.sh -t -i` succeeded.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/562
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [ 4.473 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 1.421 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [01:02 min]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 10.237 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 55.630 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [ 4.803 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [03:06 min]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [ 2.969 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 9.561 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [ 2.321 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [15:04 min]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [01:53 min]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [04:40 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [13:04 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [ 02:29 h]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [01:20 min]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.069 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 3.148 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 8.870 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:11 h
[INFO] Finished at: 2017-02-22T15:54:05-07:00
[INFO] Final Memory: 143M/1705M
[INFO] ------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/562
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #562: TINKERPOP-1626: choose() is buggy in OLAP
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---