[GitHub] [pinot] walterddr commented on pull request #9731: [multistage] decouple datablock from datatable

[GitBox <gi...@apache.org>]

walterddr commented on PR #9731:
URL: https://github.com/apache/pinot/pull/9731#issuecomment-1304666018

   > > So going forward any changes on datablock will not need to consider backward compatibility against data table.
   > 
   > I agree that we should try to decouple. But when leaf servers do the conversion of DataTable to Block (or whatever it is evolves to in future) to send to intermediary layer of servers, this logic should still continued to be written in compatible manner. Right ?
   > 
   > During deployment / rolling upgrade / restart, it is possible that intermediary servers and leaf servers are having different version.
   
   That's a good call out. Actually I have another chained PR to move the leaf servers to return non-serialized results. But this one (although refactor only) is already large enough thus I decided to split out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org