[GitHub] [airflow] feng-tao commented on a change in pull request #5350: [AIRFLOW-4716] Instrument dag loading time duration

[GitBox <gi...@apache.org>]

feng-tao commented on a change in pull request #5350: [AIRFLOW-4716] Instrument dag loading time duration
URL: https://github.com/apache/airflow/pull/5350#discussion_r293927824
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -391,6 +391,10 @@ def collect_dags(
             'dagbag_import_errors', len(self.import_errors), 1)
         self.dagbag_stats = sorted(
             stats, key=lambda x: x.duration, reverse=True)
+        for file_stat in self.dagbag_stats:
+            Stats.timing('dag.loading-duration.{}'.
+                         format(file_stat.dags),
 
 Review comment:
   I update the name to be `dag.loading-duration.dag_id1` if we have one dag per file and `dag.loading-duration.dag_id1|dag_id2` if we have multiple dags per file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services