[jira] [Commented] (KAFKA-2683) Ensure wakeup exceptions are propagated to user in new consumer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975768#comment-14975768 ] 

ASF GitHub Bot commented on KAFKA-2683:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/366

    KAFKA-2683: ensure wakeup exceptions raised to user

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-2683

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #366
    
----
commit 383d0cea274d6a7819b69cdba7b7768002822ae1
Author: Jason Gustafson <ja...@confluent.io>
Date:   2015-10-27T05:42:10Z

    KAFKA-2683: ensure wakeup exceptions raised to user

----


> Ensure wakeup exceptions are propagated to user in new consumer
> ---------------------------------------------------------------
>
>                 Key: KAFKA-2683
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2683
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>
> KafkaConsumer.wakeup() can be used to interrupt blocking operations (e.g. in order to shutdown), so wakeup exceptions must get propagated to the user. Currently, there are several locations in the code where a wakeup exception could be caught and silently discarded. For example, when the rebalance callback is invoked, we just catch and log all exceptions. In this case, we also need to be careful that wakeup exceptions do not affect rebalance callback semantics. In particular, it is possible currently for a wakeup to cause onPartitionsRevoked to be invoked multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)