You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "appletreeisyellow (via GitHub)" <gi...@apache.org> on 2023/04/18 16:39:53 UTC
[GitHub] [arrow] appletreeisyellow opened a new pull request, #35213: GH-35118: [FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
appletreeisyellow opened a new pull request, #35213:
URL: https://github.com/apache/arrow/pull/35213
### Rationale for this change
There are more inconsistency of the spec format found -- see details on the original issue #35118. https://github.com/apache/arrow/pull/35120 is the first PR with the same fix.
### What changes are included in this PR?
Use `int32` to refer to 32-bit integers rather than `int`
### Are these changes tested?
No, only comments are changed
### Are there any user-facing changes?
This clarifies a small corner case in the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35213: GH-35118: [Format][FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35213:
URL: https://github.com/apache/arrow/pull/35213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35213: GH-35118: [Format][FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35213:
URL: https://github.com/apache/arrow/pull/35213#issuecomment-1517220665
Benchmark runs are scheduled for baseline = e971cf930a40d7d1c2327d59a2525d18516a40e3 and contender = d7c5e4cfa50a4d7e46d799b78d56e39c9634332e. d7c5e4cfa50a4d7e46d799b78d56e39c9634332e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d976f23d84044d26b1b4c52226d26842...0fd53c21072a4a51bce258d1c18d9159/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9c661ae07a1e45ba858c2337583f264a...a830900b139c47a489c899487f46be2d/)
[Finished :arrow_down:8.16% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d3d8ca04edc544a1ad36cba64220cd1a...4127c559e12246cb99b010520960e290/)
[Finished :arrow_down:0.15% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0d99eb7a9d2c448e8ac894b0dd69dae6...af59cf725d474825b744719f09c2c19f/)
Buildkite builds:
[Finished] [`d7c5e4cf` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2750)
[Failed] [`d7c5e4cf` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2784)
[Finished] [`d7c5e4cf` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2748)
[Finished] [`d7c5e4cf` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2775)
[Finished] [`e971cf93` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2749)
[Failed] [`e971cf93` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2783)
[Finished] [`e971cf93` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2747)
[Finished] [`e971cf93` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2774)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35213: GH-35118: [FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35213:
URL: https://github.com/apache/arrow/pull/35213#discussion_r1170522852
##########
format/FlightSql.proto:
##########
@@ -1064,8 +1064,8 @@ enum Searchable {
* The returned schema will be:
* <
* type_name: utf8 not null (The name of the data type, for example: VARCHAR, INTEGER, etc),
- * data_type: int not null (The SQL data type),
- * column_size: int (The maximum size supported by that column.
+ * data_type: int32 not null (The SQL data type),
+ * column_size: int32 (The maximum size supported by that column.
* In case of exact numeric types, this represents the maximum precision.
* In case of string types, this represents the character length.
* In case of datetime data types, this represents the length in characters of the string representation.
Review Comment:
Could you add 2 spaces indent to corresponding documents too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] appletreeisyellow commented on a diff in pull request #35213: GH-35118: [FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "appletreeisyellow (via GitHub)" <gi...@apache.org>.
appletreeisyellow commented on code in PR #35213:
URL: https://github.com/apache/arrow/pull/35213#discussion_r1170612611
##########
format/FlightSql.proto:
##########
@@ -1064,8 +1064,8 @@ enum Searchable {
* The returned schema will be:
* <
* type_name: utf8 not null (The name of the data type, for example: VARCHAR, INTEGER, etc),
- * data_type: int not null (The SQL data type),
- * column_size: int (The maximum size supported by that column.
+ * data_type: int32 not null (The SQL data type),
+ * column_size: int32 (The maximum size supported by that column.
* In case of exact numeric types, this represents the maximum precision.
* In case of string types, this represents the character length.
* In case of datetime data types, this represents the length in characters of the string representation.
Review Comment:
Sure! Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35213: GH-35118: [FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35213:
URL: https://github.com/apache/arrow/pull/35213#issuecomment-1513482043
* Closes: #35118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35213: GH-35118: [Format][FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35213:
URL: https://github.com/apache/arrow/pull/35213#issuecomment-1517221456
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d3d8ca04edc544a1ad36cba64220cd1a...4127c559e12246cb99b010520960e290/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org