You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by dc...@apache.org on 2021/09/09 16:24:40 UTC

[datasketches-memory] branch 2.0.X updated: Skip git-commit-id maven plugin when no Git

This is an automated email from the ASF dual-hosted git repository.

dcromberge pushed a commit to branch 2.0.X
in repository https://gitbox.apache.org/repos/asf/datasketches-memory.git


The following commit(s) were added to refs/heads/2.0.X by this push:
     new e8f5b75  Skip git-commit-id maven plugin when no Git
e8f5b75 is described below

commit e8f5b7564f066ce66aab30094aedad389e3a86bc
Author: David Cromberge <dc...@apache.org>
AuthorDate: Thu Sep 9 17:23:05 2021 +0100

    Skip git-commit-id maven plugin when no Git
    
    This is often the case when running maven package
    commands from the distributed source directly as
    opposed to a cloned Github repository.
---
 datasketches-memory/pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/datasketches-memory/pom.xml b/datasketches-memory/pom.xml
index 561a0ff..4b2427d 100644
--- a/datasketches-memory/pom.xml
+++ b/datasketches-memory/pom.xml
@@ -328,7 +328,8 @@
             <format>json</format>
             <generateGitPropertiesFile>true</generateGitPropertiesFile>
             <generateGitPropertiesFilename>${project.build.directory}/git.properties</generateGitPropertiesFilename>
-            <failOnNoGitDirectory>true</failOnNoGitDirectory>
+            <!-- Maven commands are sometimes run on the release artifact directly, which is not a Git repository -->
+            <failOnNoGitDirectory>false</failOnNoGitDirectory>
             <failOnUnableToExtractRepoInfo>true</failOnUnableToExtractRepoInfo>
             <commitIdGenerationMode>full</commitIdGenerationMode>
             <includeOnlyProperties>

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org